[VTK] optional interactive orientation widget #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1635 +/- ##
==========================================
+ Coverage 85.40% 85.47% +0.07%
==========================================
Files 147 147
Lines 16717 16859 +142
==========================================
+ Hits 14277 14411 +134
- Misses 2440 2448 +8
Continue to review full report at Codecov.
|
|
In the same time I added some corrections about the camera property state change after corrections |
|
Looks good thanks! Can you document the parameter in the reference notebook? |
philippjfr
deleted the
xav/vtk_optional_interactive_orientation_widget
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following #1602 discussion I add a parameter to make the orientation widget interactive optional
By default the interactive_orientation_widget is True except for VTKRenderWindowSynchronized class where errors occur when we try to synchrnonize the view. I let the possibility to set it to true but in this case a warning is raised.
With this modification I updated the vtkjs to the latest version, it allows me to remove 2 files which were reimplementation of vtkjs corrections